feat(cloud-connection): marketplace Setup nav is plugin-owned (ADR-0029 K2 handoff)#1771
Merged
Merged
Conversation
…29 K2 handoff) Browse Marketplace ships with MarketplaceProxyPlugin; Installed Apps ships with MarketplaceInstallLocalPlugin — the entry lives and dies with the capability (OS_CLOUD_URL=off → no marketplace entries at all, instead of a dead page). Removed from platform-objects' setup-nav contributions per its own 'entries move out into capability plugins' direction. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
added a commit
that referenced
this pull request
Jun 12, 2026
…1771 #1771 moved both marketplace entries out to cloud-connection's plugins but left the now-empty contribution behind, tripping the SETUP_NAV_CONTRIBUTIONS test ('items.length > 0') and turning main CI red. The group_apps shell anchor stays in setup.app.ts and is filled entirely by capability plugins. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloud ADR-0009 P1(导航所有权移交):
MarketplaceProxyPlugin携带「Browse Marketplace」、MarketplaceInstallLocalPlugin携带「Installed Apps」(kernel:ready 时manifest.register,与 Cloud Connection 同模式)OS_CLOUD_URL=off→ Setup 零市场死链);URL 暂仍指向现有 React 页(页面元数据化 = ADR-0009 P2 分阶段)🤖 Generated with Claude Code